Upgrade icicle library to v3.4.0 #1172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So the existing Gnark is significantly faster than icicle on CPUs overall? |
jianoaix
approved these changes
Jan 29, 2025
Only for MSM, the FFT is much faster on icicle 3.4.0. But overall there is still a gap due to the MSM performance but it's closing in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Upgrades icicle library to latests version. Didn't notice much improvement on GPU side but the CPU icicle backend made some improvements. Specifically seems their FFT is faster than the one we're using.
CPU comparison:
Checks