Skip to content

fix(node): corev2 dup import with diff alias #1169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 28, 2025
Merged

fix(node): corev2 dup import with diff alias #1169

merged 2 commits into from
Jan 28, 2025

Conversation

hopeyen
Copy link
Contributor

@hopeyen hopeyen commented Jan 28, 2025 •
edited
Loading

Why are these changes needed?

I think there is a duplicate. not sure if there's a special reason, can close if so!

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@hopeyen hopeyen requested a review from ian-shim January 28, 2025 00:11
@hopeyen hopeyen merged commit 82e38f0 into master Jan 28, 2025
9 checks passed
@hopeyen hopeyen deleted the hope/small-import-fix branch January 28, 2025 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ian-shim ian-shim ian-shim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hopeyen @ian-shim