Downgrade error logs #1151
Merged
Downgrade error logs #1151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-shim
force-pushed
the
downgrade-logs
branch
from
0dd7e94 to
19a9687
Compare
dmanc
approved these changes
Jan 24, 2025
relay/server.go
Outdated
| @@ -233,6 +233,8 @@ func (s *Server) GetBlob(ctx context.Context, request *pb.GetBlobRequest) (*pb.G | |||
| return nil, api.NewErrorInvalidArg(fmt.Sprintf("invalid blob key: %v", err)) | |||
| } | |||
|
|
|||
| s.logger.Debug("GetBlob request received", "key", request.BlobKey) | |||
There was a problem hiding this comment.
Think we should use .Hex() here
ian-shim
force-pushed
the
downgrade-logs
branch
from
19a9687 to
98c134a
Compare
cody-littley
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Downgrading some error logs into warn level
Checks