[v2] fix: Ignore chunks outside operator quorums #1123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-shim
force-pushed
the
ignore-chunks-outside-op-quorums
branch
from
8c4c1f5 to
fe4e7f9
Compare
dmanc
approved these changes
Jan 17, 2025
| @@ -71,9 +71,16 @@ func (n *Node) DownloadBundles(ctx context.Context, batch *corev2.Batch, operato | |||
| if !ok { | |||
| return nil, nil, fmt.Errorf("blob version %d not found", cert.BlobHeader.BlobVersion) | |||
| } | |||
|
|
|||
| if _, ok := operatorState.Operators[quorum]; !ok { | |||
| // operator is not part of the quorum or the quorum is not valid | |||
There was a problem hiding this comment.
Do we need a warn or debug log?
ian-shim
force-pushed
the
ignore-chunks-outside-op-quorums
branch
from
fe4e7f9 to
a426683
Compare
pschork
pushed a commit
that referenced
this pull request
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Operator should not download/process chunks outside its participating quorums.
Checks