Skip to content

KMS client from AWS config #1103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 14, 2025
Merged

KMS client from AWS config #1103

merged 3 commits into from
Jan 14, 2025

Conversation

pschork
Copy link
Contributor

@pschork pschork commented Jan 13, 2025

Why are these changes needed?

Need to load KMS client from AWS config so that it can utilize the AWS role based service account.

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@pschork pschork force-pushed the pschork/controller_kms branch from 8daa5b7 to bb6e007 Compare January 13, 2025 23:12
@pschork pschork requested a review from cody-littley January 13, 2025 23:13
@pschork pschork marked this pull request as ready for review January 13, 2025 23:14
@pschork pschork merged commit 0f14d1c into master Jan 14, 2025
9 checks passed
@pschork pschork deleted the pschork/controller_kms branch March 6, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cody-littley cody-littley cody-littley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pschork @cody-littley