[v2] eth address as account id #1053
Merged
+160
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hopeyen
changed the title
ian-shim
reviewed
Dec 21, 2024
core/auth/v2/authenticator.go
Outdated
| accountId := header.PaymentMetadata.AccountID | ||
| pubKey := crypto.PubkeyToAddress(*sigPublicKeyECDSA).Hex() | ||
|
|
||
| if pubKey != accountId { |
There was a problem hiding this comment.
Here we're comparing strings, but this will fail if accountID isn't checksummed string.
I think it's safer to convert accountID to common.Address (common.HexToAddress()) and compare bytearrays using Address.Cmp()
Do we have a test capturing this?
There was a problem hiding this comment.
Updated to use address type.
We have auth_test that check for authenticating the requests, but not as specific as whether it is checksum or not.
hopeyen
force-pushed
the
hope/account-id
branch
from
4e68a7c to
6d789e8
Compare
ian-shim
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
just for investigating account behaviors
Checks