Skip to content
This repository was archived by the owner on Jul 23, 2025. It is now read-only.

Conversation

ethenotethan
Copy link
Contributor

@ethenotethan ethenotethan commented Jun 25, 2025

Fixes Issue

Fixes #

Changes proposed

Updates example env cert verifier address for v2 sepolia to use latest verifier vs legacy.

Screenshots (Optional)

Note to reviewers

@Copilot Copilot AI review requested due to automatic review settings June 25, 2025 23:02
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the example environment file for Sepolia by replacing the certificate verifier address with a new value.

  • Updated the EIGENDA_PROXY_EIGENDA_V2_CERT_VERIFIER_ROUTER_OR_IMMUTABLE_VERIFIER_ADDR value
Comments suppressed due to low confidence (1)

.env.exampleV2.sepolia:50

  • [nitpick] The new address uses mixed-case EIP-55 checksumming while the previous one was lowercase. For consistency across your example env files, choose one casing style (e.g., all lowercase or EIP-55 checksummed) and apply it uniformly.
EIGENDA_PROXY_EIGENDA_V2_CERT_VERIFIER_ROUTER_OR_IMMUTABLE_VERIFIER_ADDR=0x58D2B844a894f00b7E6F9F492b9F43aD54Cd4429

@ethenotethan ethenotethan requested review from samlaf and litt3 June 25, 2025 23:06
Copy link
Collaborator

@samlaf samlaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did we not catch this in tests/CI before your manual tests? Feel like we should add a test to catch these kinds of regressions in the future.

Oh is it because the tests are populated with addresses manually which are different from the ones here? This is another issue with keeping all these different configs everywhere, and why @litt3 was against having these example files.

Is there an easy way we can compare the values here to those hardcoded in the proxy binary and fail if they differ?

@litt3
Copy link
Collaborator

litt3 commented Jun 26, 2025

How did we not catch this in tests/CI before your manual tests? Feel like we should add a test to catch these kinds of regressions in the future.

Oh is it because the tests are populated with addresses manually which are different from the ones here? This is another issue with keeping all these different configs everywhere, and why @litt3 was against having these example files.

Is there an easy way we can compare the values here to those hardcoded in the proxy binary and fail if they differ?

@samlaf @ethenotethan Maybe instead of having these example files, it would suffice to just have a list of env vars that should be set? That would force users to thoughtfully consider every value, but at least they would know every value that needs to be set for an functioning system. This strategy would also prevent stuff like this address getting out of sync, which is so easy to do when we don't have checks to verify.

@ethenotethan
Copy link
Contributor Author

@litt3 @samlaf filed a linear issue for tracking

@ethenotethan ethenotethan merged commit 866654a into main Jun 26, 2025
18 of 19 checks passed
@ethenotethan ethenotethan deleted the ethenotethan--update-example-env-sepolia-addresses branch June 26, 2025 19:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants