Updating dotnet branch #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Its now fully compatible with Unity 2019. This fixes issue #64 which was caused by Unity deprecating the WWW class. Fixed a bunch of other unity related warnings too. While the project is now Unity 2019, you can still run it in older versions of unity. I will probably do another commit to revert the project back to Unity 5. I should really have seperate asset packs, but there is no easy way to do that.
(Just triggering another build)
Fixing `package` spelling mistake
If the SetPresence was called within a few milliseconds (less than 100ms) repeatedly, the pipe would not have enough time to process the messages and will throw errors. This indicates an underlying flaw with the mutexing of the pipe, but as a quick fix I have done the following: Ignored presences that are identical to the current presence ( this can be disabled using the `SkipIdenticalPresence` property ) Added a command queue size. This cannot be changed at the moment and will only keep `512` _pending_ commands at a time. Additional requests will cause the oldest to be removed. In reality, this limit should never be hit unless something horribly went wrong and someone is sending a new presence every millisecond. Another issue was that the stored current presence was not being cloned. This resulted in situations where if you retained your copy of the Rich Presence object, when a new one comes through discord that would have been used instead. Hopefully these changes will help with issue #71
This was added a while ago but I forgot to include it into this library. The Unity Package will need this to be ported in too still.
It was broken
Output is already defined via docfx.json
This helps docfx find these pages while making it clearer to the dev
- Remove properties that are not currently used or valid + Add xrefservice * Target csproj instead of cs, allowing docfx to understand the build process better
Fix docs generation issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.