Unity 5.5 #7
Merged
Unity 5.5 #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unity 5.5 only uses language features for C# 5 and all sorts of issues where occuring. It was easier to down grade the library and replace all the features with their long equivilent. Doesn't do anything bad or good for performance, just makes it slightly more annoying to write. Thats all.
Seems to be crashing when the pipe tries to abort.
I swear this is like the 10th time i have done this.
# Conflicts: # Discord RPC/RichPresence.cs
Since Unity does not support duplex pipes and there is no other way around it, I need to use native pipe connections. Instead of writing this entire thing with unsafe code again, I have abstracted the connection so all I have to do is assign what kind of pipe to use to the client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating some major changes from the unity branch. In particularly on how the reading works and abstracting away the pipe to allow for native solutions versus managed.