Skip to content

Reduce overhead in ManagedNamedPipeClient during connection loop #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 16, 2023
Merged

Reduce overhead in ManagedNamedPipeClient during connection loop #237

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
426b752
Reduce overhead in `ManagedNamedPipeClient` during connection loop
peppy Jul 13, 2023
2ec401e
Actually update proposed value with change
peppy Jul 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion DiscordRPC/IO/ManagedNamedPipeClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,9 @@ private bool AttemptConnection(int pipe, bool isSandbox = false)
{
Logger.Info("Attempting to connect to '{0}'", pipename);
_stream = new NamedPipeClientStream(".", pipename, PipeDirection.InOut, PipeOptions.Asynchronous);

// Intentionally use a timeout of 0 here to avoid spinlock overhead.
// We are already performing local retry logic, so this is not required.
_stream.Connect(1000);

//Spin for a bit while we wait for it to finish connecting
Expand Down Expand Up @@ -378,7 +381,7 @@ public void Close()
return;
}

//flush and dispose
//flush and dispose
try
{
//Wait for the stream object to become available.
Expand Down