.NET 3.5 Implementation #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are lots of errors.
WOOOO! You can now set presences
This allows writes and reads at the same time.
Can now connect and send messages properly. Will update current RPC with responses from Discord.
Abstracting away the RpcConnection to a main manager. Added a bunch of comments to document the flow better and renamed some functions to better describe how they work. Gave the queue an actual Queue object and added ClearPresence and Close.
This was cleared up by Mason in the API server.
Reworked the RPC Connection and so now its continous and always connected, queing up messages when not available and processing them once connected again.
I suck at maths and cannot really see where I am going wrong. So instead I just wrapped it in basically a clamp.
Cause secrets are fun. Probably will switch to a ASCII encoder instead of a UTF8 tho, just so we get some nicer characters...... might even make it a lookup instead.
Finished implementing the join / spectate feature. Finished the queue and fixed the long running bug of broken pipes. Refactored and moved some things around too.
This is a super useful feature for debugging.
Added actual events you can add listeners too. Just use the Invoke() method to call all the events that were queued up. Logging has been changed from directly Console.WriteLine to a new expandable type. This type will allow people to replace the default logger with their own. By default there are 2 loggers, NullLogger (which ignores all logs) and ConsoleLogger (which reimplements the Console.WriteLine). These logs are not thread safe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reimplemented the library using .NET 3.5. Added more support for things such as the Join / Spectate feature, proper threading and connection handling, proper events and generally finished the library. Working on examples now in the unity-5.5 branch instead.