Skip to content

Conversation

KianaKaslana
Copy link
Contributor

Work done in this request

Build Cleanup

The current master branch had two minor issues that I've cleaned up:

  1. There is a missing file in the csproj (PipeConnection.cs) that I've removed
  2. Added a mkdir Post Build step to ensure the Unity Example folder exists before attempting to copy the dll there as this shows up as an error in VS

Build Script

I've added a basic Cake script to make is easier to build the project (no need to open Visual Studio). The script also makes it easy to roll the project onto a build server (like AppVeyor).

I've also added a nuspec file to make it easy to build a Nuget package (via the script) and push it to Nuget


Things to consider

  • It would be beneficial to implement automated versioning (like SemVer) for easy deployment to Nuget. If you want I can assist with this, but note that it does take a bit of work to ensure numbering works correctly
  • Automating the build with AppVeyor would make automated releases to Nuget easier. I cannot set up AppVeyor for your repository, but if you want to do it I can provide guidance on how to do it (it is very easy when using the Cake build script)

Kiana

KianaKaslana and others added 3 commits March 27, 2018 08:45
- Remove missing file PipeConnection.cs
- Added post build event to ensure the folder we are copying to in Unity Example actually exists, this prevents an error that occur when trying to copy the file to a folder that does not exist
- Added Cake build script
- Updated gitignore to correctly ignore the Cake tools directory
- Updated README with instructions on using Cake to build the project
- Added nuspec file to build a nuget package
@Lachee
Copy link
Owner

Lachee commented Mar 27, 2018

I have pull your branch and thank you for your help. A nuget package would be really nice, but I think that should wait until the next milestone. My latest work has also introduced a C++ library, which may complicate things. This is only for unity though, so hopefully no big deal.

@Lachee Lachee merged commit 88aae05 into Lachee:master Mar 27, 2018
@KianaKaslana
Copy link
Contributor Author

It's a pleasure. 😄
No worries, most of the machinery for generating the Nuget package is already in there so should be easy to roll out later.
Feel free to give me a shout if you need assistance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants