Skip to content

Conversation

michaelmckinsey1
Copy link
Collaborator

@michaelmckinsey1 michaelmckinsey1 commented Jun 7, 2025

Fixes #248

extrap pins 1.18 https://github.com/extra-p/extrap/blob/c29cf6e87adbd4506106d2fa5fe5c10cac338d2f/setup.py#L58, so we need to drop testing or add a separate test with numpy 1.18

@michaelmckinsey1 michaelmckinsey1 self-assigned this Jun 7, 2025
@michaelmckinsey1 michaelmckinsey1 linked an issue Jun 7, 2025 that may be closed by this pull request
@michaelmckinsey1 michaelmckinsey1 requested a review from ilumsden June 7, 2025 00:32
@michaelmckinsey1
Copy link
Collaborator Author

Tests will fail until #251 merged

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.13%. Comparing base (545af35) to head (2fd7b93).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #249      +/-   ##
===========================================
+ Coverage    83.06%   83.13%   +0.06%     
===========================================
  Files           65       65              
  Lines         4452     4452              
===========================================
+ Hits          3698     3701       +3     
+ Misses         754      751       -3     
Files with missing lines Coverage Δ
setup.py 0.00% <ø> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@slabasan slabasan added area-external Issues and PRs related to external libraries used by Thicket status-ready-for-review This PR is ready to be reviewed by assigned reviewers labels Jul 3, 2025
@slabasan slabasan merged commit 89ab916 into LLNL:develop Jul 3, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-external Issues and PRs related to external libraries used by Thicket status-ready-for-review This PR is ready to be reviewed by assigned reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Numpy < 2.0 dependency
3 participants