Skip to content

Conversation

@adayton1
Copy link
Member

Summary

  • This PR is a bugfix
  • It does the following:
    • std::result_of was deprecated in C++17 and removed in C++20
    • Uses std::invoke_result_t instead
    • Handles the first case in issue C++20 support #1718.

Copy link
Member

@kennyweiss kennyweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adayton1 !

@adayton1 adayton1 mentioned this pull request Nov 12, 2025
3 tasks
@adayton1 adayton1 requested a review from robinson96 November 12, 2025 18:14
Copy link
Contributor

@Arlie-Capps Arlie-Capps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @adayton1 !

Copy link
Member

@rhornung67 rhornung67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adayton1 did you say earlier that there are similar changes needed to some other files?

@adayton1
Copy link
Member Author

@adayton1 did you say earlier that there are similar changes needed to some other files?

#1718

  • CLI11.hpp, but I think it is correctly guarded with macros.
  • sol.hpp, but I don't feel comfortable trying to mess with that library.

@adayton1
Copy link
Member Author

I do not have permissions to merge, so feel free to push the button @kennyweiss or @rhornung67.

@rhornung67 rhornung67 merged commit 1ca4711 into develop Nov 12, 2025
15 checks passed
@rhornung67 rhornung67 deleted the bugfix/result_of branch November 12, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants