Fix array lengths in EOS::runKokkosVariant #597
Merged
+9
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhornung67
approved these changes
Dec 10, 2025
crtrott
approved these changes
Dec 10, 2025
Collaborator
crtrott
left a comment
crtrott
left a comment
There was a problem hiding this comment.
Yeah looks like this is more in line with the actual test :-), not sure if the original one was changed at some point or this was just wrong from the beginning and somehow didn't crash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A bug in the array lengths used in EOS::runKokkosVariant caused memory corruption resulting in a crash.