Skip to content

Conversation

@KevFan
Copy link
Contributor

@KevFan KevFan commented Nov 28, 2025

Description

Closes: #1689
Requires: #1704

Adds sources field to wasm plugin config for each action which lists all the policies that was considered for this action. Overridden policies are omitted

Verification

  • Passing tests should be enough

If you want to verify manually

  • Create local cluster
make local-env-setup
make run
  • Create Kuadrant CR
kubectl apply -f - <<EOF
apiVersion: kuadrant.io/v1beta1
kind: Kuadrant
metadata:
  name: kuadrant
  namespace: kuadrant-system
EOF
  • Watch wasm plugin resource and verify that the sources field are as expected as you walkthrough the guides
watch "kubectl get wasmplugins -A  -o yaml | yq '.items[0].spec'"

@KevFan KevFan changed the title refactor: track policies sources in wasmplugin config feat: track policies sources in wasmplugin config Dec 2, 2025
@KevFan KevFan marked this pull request as ready for review December 2, 2025 10:02
@KevFan KevFan requested a review from a team as a code owner December 2, 2025 10:02
@KevFan KevFan self-assigned this Dec 2, 2025
@KevFan KevFan added kind/enhancement New feature or request size/medium labels Dec 2, 2025
adam-cattermole
adam-cattermole previously approved these changes Dec 2, 2025
Copy link
Member

@adam-cattermole adam-cattermole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, managed to verify it with the wasm-shim reading these bits and it's looking great!

@KevFan KevFan changed the base branch from trace to main December 4, 2025 12:12
@KevFan KevFan dismissed adam-cattermole’s stale review December 4, 2025 12:12

The base branch was changed.

@KevFan
Copy link
Contributor Author

KevFan commented Dec 4, 2025

Rebased due to conflicts

@KevFan KevFan added this pull request to the merge queue Dec 4, 2025
Merged via the queue into Kuadrant:main with commit ca53912 Dec 4, 2025
29 of 32 checks passed
@KevFan KevFan deleted the sources-wasm branch December 4, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement New feature or request size/medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Uniquely identify "effective policies"

3 participants