Skip to content

Conversation

nitanmarcel
Copy link
Contributor

@nitanmarcel nitanmarcel commented Jan 25, 2025

An attempt for a more modern looking design.

UI Changes

  • The main top app bar is now an AppBarLayout with the hight collapsingToolbarLayoutMediumSize
  • The Home page has been moved to a new Shortcuts page
  • The About page is replacing the Home page with a better display of the app's information
  • The Settings page got the app logo removed, instead the app logo is now visible in the Home page
  • Removed rounded corners from the navigation bar
  • Remove game dialog is now more closely to Material 3 Design language
  • Environment Settings related elements are also updated
  • Added a search bar to the new shortcuts fragment
  • Fix uneven margins in Shortcuts (Old home screen)
  • Add a tutorial when the user starts the app for the first time.
  • Light mode design fixed
  • Material 3 styled dialog buttons
  • Filemanager fade animation and improvements

Non-UI Changes

  • Added drag and drop functionality for shortcuts items
  • Improve about loading by gathering info in a separate thread
  • Sanatize paths to about conflicts with ' characters used in commands execution"

Media

https://github.com/user-attachments/assets/c4af792f-3ab8-41d2-aa9b-c5fac377beab
https://github.com/user-attachments/assets/4d97cb0e-4345-488c-a488-18ad849c8963

@Crauzer58
Copy link

Instead Home, maybe we can use add game button.
And put wine desktop inside navigation drawer,
And File Manager for installing some rat files

@Crauzer58
Copy link

Add this_20250126_095351_0000

@nitanmarcel
Copy link
Contributor Author

Instead Home, maybe we can use add game button. And put wine desktop inside navigation drawer, And File Manager for installing some rat files

Not so sure about the add game button, but I'm 100% sure about the search button :)

@Crauzer58
Copy link

Crauzer58 commented Jan 26, 2025

Instead Home, maybe we can use add game button. And put wine desktop inside navigation drawer, And File Manager for installing some rat files

Not so sure about the add game button, but I'm 100% sure about the search button :)

Its like file manager, but just have function to add game to home screen, its more easy to understand for new user.

Or you can change the file manager, but i prefer add game button

@nitanmarcel
Copy link
Contributor Author

Instead Home, maybe we can use add game button. And put wine desktop inside navigation drawer, And File Manager for installing some rat files

Not so sure about the add game button, but I'm 100% sure about the search button :)

Its like file manager, but just have function to add game to home screen, its more easy to understand for new user.

Or you can change the file manager, but i prefer add game button

Well the issue is, there's no way as far as I know to get the installed apps outside wine.

Maybe @KreitinnSoftware can give me an hand here

@nitanmarcel nitanmarcel changed the title Design improvements WIP: Design improvements Jan 26, 2025
@nitanmarcel nitanmarcel marked this pull request as draft January 26, 2025 10:41
@nitanmarcel
Copy link
Contributor Author

Converted to Draft since it will cover multiple places in the UI

@nitanmarcel
Copy link
Contributor Author

screen-20250126-133301.2.mp4

@nitanmarcel
Copy link
Contributor Author

Uploading screen-20250126-133301~2.mp4…

Add this_20250126_095351_0000

screen-20250126-144712.mp4

@nitanmarcel
Copy link
Contributor Author

Coming back to the add app idea, I really have no slightly idea on how to implement it without duplicating what the file manager does or removing functionality.

I'm thinking of something like a showcase when you open a folder that contains an exe for the first time. https://github.com/florent37/TutoShowcase

@Crauzer58
Copy link

Crauzer58 commented Jan 26, 2025

Coming back to the add app idea, I really have no slightly idea on how to implement it without duplicating what the file manager does or removing functionality.

I'm thinking of something like a showcase when you open a folder that contains an exe for the first time. https://github.com/florent37/TutoShowcase

Its nice, this will very helpfull with new user

@nitanmarcel
Copy link
Contributor Author

Coming back to the add app idea, I really have no slightly idea on how to implement it without duplicating what the file manager does or removing functionality.
I'm thinking of something like a showcase when you open a folder that contains an exe for the first time. https://github.com/florent37/TutoShowcase

Its nice, this will very helpfull with new user

Or maybe something minimal like this?

https://github.com/skydoves/Balloon

@Crauzer58
Copy link

Crauzer58 commented Jan 26, 2025

Coming back to the add app idea, I really have no slightly idea on how to implement it without duplicating what the file manager does or removing functionality.
I'm thinking of something like a showcase when you open a folder that contains an exe for the first time. https://github.com/florent37/TutoShowcase

Its nice, this will very helpfull with new user

Or maybe something minimal like this?

https://github.com/skydoves/Balloon

Minimal is cool, but its more what @KreitinnSoftware want.

For me, i prefer use TutoShowCase
If we use Baloon
we will use it too much, you know how many words confuse new users.

It's better to improvise information from the setting

@nitanmarcel
Copy link
Contributor Author

nitanmarcel commented Jan 26, 2025

Coming back to the add app idea, I really have no slightly idea on how to implement it without duplicating what the file manager does or removing functionality.
I'm thinking of something like a showcase when you open a folder that contains an exe for the first time. https://github.com/florent37/TutoShowcase

Its nice, this will very helpfull with new user

Or maybe something minimal like this?
https://github.com/skydoves/Balloon

Minimal is cool, but its more what @KreitinnSoftware want.

For me, i prefer use TutoShowCase If we use Baloon we will use it too much, you know how many words confuse new users.

It's better to improvise information from the setting

I've actually found a more up to date library
Screenshot_20250126-161009

@nitanmarcel
Copy link
Contributor Author

Coming back to the add app idea, I really have no slightly idea on how to implement it without duplicating what the file manager does or removing functionality.
I'm thinking of something like a showcase when you open a folder that contains an exe for the first time. https://github.com/florent37/TutoShowcase

Its nice, this will very helpfull with new user

Or maybe something minimal like this?
https://github.com/skydoves/Balloon

Minimal is cool, but its more what @KreitinnSoftware want.

For me, i prefer use TutoShowCase If we use Baloon we will use it too much, you know how many words confuse new users.

It's better to improvise information from the setting

I've implemented the tutorial

screen-20250126-201551.mp4

@nitanmarcel nitanmarcel marked this pull request as ready for review January 26, 2025 18:19
@nitanmarcel nitanmarcel changed the title WIP: Design improvements Design improvements Jan 26, 2025
@nitanmarcel nitanmarcel marked this pull request as draft January 27, 2025 09:55
@nitanmarcel nitanmarcel marked this pull request as ready for review January 28, 2025 09:09
@nitanmarcel
Copy link
Contributor Author

It should be ready for review since I don't see any other flaws myself in the UI.

@KreitinnSoftware when you have time maybe review this and tell if any changes could be added or reverted

@KreitinnSoftware
Copy link
Owner

Nice work, I will review this PR later

@KreitinnSoftware
Copy link
Owner

Screenshot_20250128-182755_MiceWine
I have tested the pr here and bugged on settings

@KreitinnSoftware
Copy link
Owner

I think the font that used before on title on top MiceWine is better

@nitanmarcel
Copy link
Contributor Author

Screenshot_20250128-182755_MiceWine I have tested the pr here and bugged on settings

This is weird. Is there any way to reproduce it or it just happened when you've opened the app?

@KreitinnSoftware
Copy link
Owner

Screenshot_20250128-182755_MiceWine I have tested the pr here and bugged on settings

This is weird. Is there any way to reproduce it or it just happened when you've opened the app?

Just opened the app

@nitanmarcel
Copy link
Contributor Author

I think the font that used before on title on top MiceWine is better

thanks for the HeadsUp, I haven't noticed that originally it has a font set to it.

I've restored the original font

@nitanmarcel
Copy link
Contributor Author

Screenshot_20250128-182755_MiceWine I have tested the pr here and bugged on settings

This is weird. Is there any way to reproduce it or it just happened when you've opened the app?

Just opened the app

Screenshot_20250128-182755_MiceWine I have tested the pr here and bugged on settings

This is weird. Is there any way to reproduce it or it just happened when you've opened the app?

Just opened the app

Can you please try again?

@KreitinnSoftware
Copy link
Owner

Screenshot_20250128-182755_MiceWine I have tested the pr here and bugged on settings

This is weird. Is there any way to reproduce it or it just happened when you've opened the app?

Just opened the app

Screenshot_20250128-182755_MiceWine I have tested the pr here and bugged on settings

This is weird. Is there any way to reproduce it or it just happened when you've opened the app?

Just opened the app

Can you please try again?

Now worked fine, I will check if have any other issues and merge

@KreitinnSoftware KreitinnSoftware merged commit 05eacfb into KreitinnSoftware:master Jan 29, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants