Add MANIFEST.in to include demo and docs in PyPi tarballs, fixes #425 #428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm sorry but why would you want to have the docs in the PyPi package? I see no use case and it'll surely increase the package size. |
| @@ -0,0 +1,3 @@ | |||
| exclude .* pygal_doc_old.tar.xz tox.ini | |||
| graft demo docs tests | |||
There was a problem hiding this comment.
include all files under dir
|
We at Gentoo rely on PyPI tarballs to build docs, I am pretty sure that this is also the case for Debian maintainers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Distributions often rely on PyPI tarballs to build docs. The current PyPI tarballs do not contain them. The sdist file that I obtain with the MANIFEST.in file also contains COPYING, so this fixes #425.
I tried to remove a few files that aren't needed like the old doc tarball, feel free to change the MANIFEST.in file.