Skip to content

fix: not sending form urlencoded properly in JS fetch snippets #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
reynolek merged 2 commits into from
Sep 3, 2021
Merged

fix: not sending form urlencoded properly in JS fetch snippets #218

reynolek merged 2 commits into from
Sep 3, 2021
+13 −3

Conversation

@erunion
Copy link
Contributor

@erunion erunion commented May 13, 2021

JS fetch body needs to be a string, and we were sending objects on x-www-url-formencoded requests. This fixes that by wrapping those objects in new URLSearchParams().

@reynolek reynolek merged commit 6b85ba2 into Kong:master Sep 3, 2021
@erunion erunion deleted the fix/not-sending-form-urlencoded-properly branch September 4, 2021 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@reynolek reynolek reynolek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@erunion @reynolek