Skip to content

fix: node-fetch doesn't support the qs option #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
reynolek merged 1 commit into from
Apr 20, 2021
Merged

fix: node-fetch doesn't support the qs option #213

reynolek merged 1 commit into from
Apr 20, 2021

Conversation

@erunion
Copy link
Contributor

@erunion erunion commented Apr 20, 2021

This fixes the Node fetch target to no longer supply query params through the qs option (which it does not support).

Fixes #201

@erunion erunion mentioned this pull request Apr 20, 2021
Closed
@reynolek
Copy link
Contributor

reynolek commented Apr 20, 2021

Thanks as always @erunion !

@reynolek reynolek merged commit d82a992 into Kong:master Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@reynolek reynolek reynolek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Node.js / Fetch - qs isn't supported

2 participants

@erunion @reynolek