Skip to content

Conversation

@jonasholbech
Copy link
Contributor

Vanilla JS did not return the json from the request, the node.js version does, now they should behave the same

Vanilla JS did not return the json from the request, the node.js version does, now they should behave the same
@CLAassistant
Copy link

CLAassistant commented Mar 30, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@erunion erunion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the tests for the JS target? They need this line added to them.

@jonasholbech
Copy link
Contributor Author

Let me see if I can find those :-)

@erunion
Copy link
Contributor

erunion commented Mar 30, 2021

@jonasholbech
Copy link
Contributor Author

thanks @erunion

@reynolek reynolek merged commit bddb81a into Kong:master Apr 5, 2021
@reynolek
Copy link
Contributor

reynolek commented Apr 5, 2021

Thanks for the contribution @jonasholbech!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants