Skip to content

feat: updating javascript targets to use const instead of var #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
reynolek merged 1 commit into from
Aug 17, 2020
Merged

feat: updating javascript targets to use const instead of var #174

reynolek merged 1 commit into from
Aug 17, 2020

Conversation

@erunion
Copy link
Contributor

@erunion erunion commented Aug 7, 2020

  • Updates all Javascript and Node targets to use const instead of var.
  • Fixes some inconsistencies with the unirest target where it was adding unnecessary linebreaks and indents in snippets.
  • In the jquery target, I've added a semicolon to the settings object to stay consistent with the rest of the snippet.

reynolek
reynolek suggested changes Aug 16, 2020
View reviewed changes
@reynolek reynolek merged commit 155e563 into Kong:master Aug 17, 2020
@erunion erunion deleted the feat/js-consistency branch August 17, 2020 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@reynolek reynolek reynolek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@erunion @reynolek