Open Files, Command Output, and Notifications Updates #3672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ssigwart
commented
Feb 4, 2019
ssigwart
commented
- Filter option for open files.
- Comment output clear option.
- Notifications clear option.
- Filter option for open files - Comment output clear option - Notifications clear option
Member
|
Hey @ssigwart ! This is awesome, really appreciate the work here! But could you please submit these as separate PRs? You're doing 3 wildly different things all in one PR. Makes it hard to review each in their own merit, since we're not just reviewing the code, we're also reviewing feature implications. |
Contributor
Author
|
I split them up. I didn't know if you'd want 4 PRs in a day. |
This was referenced Feb 5, 2019
Member
We loves PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.