Improve type analysis #407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes invalid types for the `getBreadcrumbsArray` methods and fixes some type issues reported by phpstan. Some dead code (related to supporting old PHP or Symfony versions) is also cleaned.
stof
commented
Jun 13, 2025
| "conflict": { | ||
| "twig/twig": "<1.42.3 || >=2,<2.9" | ||
| "symfony/http-foundation": "<5.4", | ||
| "twig/twig": "<2.16" |
There was a problem hiding this comment.
this aligns the conflict rule with our Twig dev requirement.
Closed
Fix the way Symfony versions are locked for LTS jobs to avoid changing conflict rules Run a job with dev deps instead of with Symfony 7.2 with dev min stability, to reduce the maintenance work.
garak
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes invalid types for the
getBreadcrumbsArraymethods and fixes some type issues reported by phpstan.Some dead code (related to supporting old PHP or Symfony versions) is also cleaned.