Skip to content

Conversation

simonw
Copy link
Contributor

@simonw simonw commented Jun 16, 2019

As discussed in django/asgiref#87 and implemented in django/asgiref#92

The PR adding raw_path to the ASGI specification will hopefully be merging very shortly. This change to Uvicorn should be considered blocked until the specification has been updated.

@simonw simonw changed the title Implemented scope["raw_path"] for both HTTP and websockets Implement scope["raw_path"] for both HTTP and websockets Jun 16, 2019
@simonw
Copy link
Contributor Author

simonw commented Jun 16, 2019

Previously discussed in #261 and #354 - but that was before the change to the ASGI specification.

Copy link
Contributor

@lovelydinosaur lovelydinosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crackin' stuff! Suggested a few tiny tweaks.

@lovelydinosaur
Copy link
Contributor

Really nice to see that supporting this actually needs almost no extra implementation.

@simonw
Copy link
Contributor Author

simonw commented Jun 17, 2019

The specification has now been updated to add raw_path: django/asgiref#92

@lovelydinosaur lovelydinosaur merged commit 184fb41 into Kludex:master Jun 18, 2019
@lovelydinosaur
Copy link
Contributor

Released as 0.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants