Make ExtendedPropertyReassignmentEventArgs & ExtendedPropertyInitialValueSetEventArgs public #887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alueSetEventArgs public
ericstj
reviewed
Aug 14, 2025
| string senderName = null, | ||
| MessageImportance importance = MessageImportance.Low) | ||
| : base(subcategory: null, code: null, file: file, lineNumber: line, columnNumber: column, 0, 0, message, helpKeyword, senderName, importance) | ||
| : base(propertyName, previousValue, newValue, location: message, message) |
There was a problem hiding this comment.
Is there a reason why we can't just call this constructor directly? Why do we need our own type?
There was a problem hiding this comment.
I see your point and now I can't justify why these were added on the first place.
Removed.
KirillOsenkov
approved these changes
Aug 14, 2025
This was referenced Sep 22, 2025
Merged
This was referenced Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
#885
Changes made
This code makes ExtendedPropertyReassignmentEventArgs & ExtendedPropertyInitialValueSetEventArgs public and they derive from the corresponding MSBuild types.