perf: avoid array.shift, use a linked list #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of stack promises into an array, it uses a double linked list. The main advantage is `queue.shift` hurts the performance when for big arrays O(n), while a double linked list keep access time constant O(1)
Since the code is only adding elements to the end of the list and removing elements from the start of the list, that can be handled using a simple linked list.
Kikobeats
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of stacking promises into an array, it uses a linked list
The main advantage is that
queue.shifthurts performance for large arrays cases because O(n), while a linked list keeps access time O(1)Related: nodejs/node#42449 (comment)