This repository was archived by the owner on Oct 2, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 737
Added DE152 from DE122 #2932
Open
valerionew
wants to merge
4
commits into
KiCad:master
Choose a base branch
from
valerionew:LCD
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Added DE152 from DE122 #2932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @valerionew , thanks for contributing, A few comments I have during my review:
Else just need to wait the footprint (please provide link to the PR when available - Important note: try to do it befoe the 2020-09-01 because the repository will be locked in preparation of the KiCad V6 and we will not accept new PR) Cheers, |
5 tasks
Hey Joel, sorry for those rookie mistakes, i haven't made a contribution in a while! Should be all fixed now, footprint PR is here: |
Footprint PR: KiCad/kicad-footprints#2423
Datasheet: https://www.tme.eu/Document/a8ad3d6d1be7f7b544cda7e86ae7bac8/DE152.pdf

In preparation for the KiCad v6 release this repository will be locked down on Sept 1, 2020. No new pull requests will be accepted. Existing pull requests can be worked on until Oct 1, 2020. Changes breaking v5.1 compatibility can be merged starting Sept 1, 2020.
On Oct 1, 2020 this repository, including issues and pull requests, will be archived and transferred to gitlab.com. In order for your pull requests and issues to be imported into GitLab you must set your email address on GitHub to public and use the same address for your GitLab account. Or login to GitLab at least once using the GitHub icon. Otherwise the importer can't correlate the account information and the issues/comments on GitLab will be owned by
kicad-bot
(importer documentation).We plan to convert the library to the new v6 S-expr format after it is imported to GitLab. That also means that old pull requests will need to be redone with the v6 format if they are not merged before then.
All contributions to the kicad library must follow the KiCad library convention
Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:
Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing additional info like the screenshot of the symbol editor pin table (or for high pin counts converted to csv) sorted in the same way as the pin table in the datasheet and a direct link to the datasheet page that contains the pin table.