ToyCar - PBR Next Phase1 Sample Model #278
Conversation
|
Is this PR supposed to replace #268? If not, either or both of them are likely to have to change their names. |
|
It is not intended to replace #268. I would be more than happy to rename this model, but I couldn't come up with a name that made sense in this repository. I had considered ToyCarPhase1, but I was concerned that the "Phase1" name only makes sense to the working group (these extensions represent phase 1 of PBR Next). I'm open to any suggestions on a rename here. If this gets merged before #268, then in my mind it would make sense to rename that model (e.g. ToyCarSpecular). |
|
How about ToyCarClearcoatSheenTransmission, or maybe with an underscore or
dash in there, e.g. ToyCar_ClearcoatSheenTransmission . Then for subsequent
revisions we could name them with whatever extensions are being demoed.
…On Fri, Nov 27, 2020, 9:32 AM abwood ***@***.***> wrote:
It is not intended to replace #268
<#268>. I would be
more than happy to rename this model, but I couldn't come up with a name
that made sense in this repository. I had considered ToyCarPhase1, but I
was concerned that the "Phase1" name only makes sense to the working group
(these extensions represent phase 1 of PBR Next). I'm open to any
suggestions on a rename here.
If this gets merged before #268
<#268>, then in my
mind it would make sense to rename that model (e.g. ToyCarSpecular).
CC @proog128 <https://github.com/proog128> or @emackey
<https://github.com/emackey>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#278 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJSQ3DATQHYO4BCFV7NO4NLSR62AXANCNFSM4UD5XEIA>
.
|
|
I would prefer not to rename from simply "ToyCar", although the model may need to move to the extensions section of the readme. As for the other ToyCar in #268, those extensions are still under review & discussion. I'm not sure that version of ToyCar demonstrates their effects in an intuitive way, like this version does with its extensions. We might not even end up using a car to demonstrate those extensions when complete, depending how things go. So my vote would be, this version of the ToyCar should get merged first (pending a bit more review), and samples featuring not-yet-ratified extensions can be worked out later on. Sound good? |
- Fixed decal edges in the normal map - Added 8 cameras
|
Just a note: I tested this model in the Babylon.js sandbox with all of the extensions turned off and it still rendered properly. 👍 This model looks good to me barring some small comments.
|
Co-authored-by: Gary Hsu <[email protected]>
|
Ah, are you talking about the indents?
The Max2Babylon exporter produces ascii glTF with no line breaks, which
makes it really difficult to edit by hand. So I used https://beautifier.io/
to reformat before editing.
Is Visual Studio Code the preferred editor for ascii glTF?
…On Mon, Nov 30, 2020 at 5:22 PM abwood ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In 2.0/ToyCar/glTF/ToyCar.gltf
<#278 (comment)>
:
> + "byteLength": 619432,
+ "byteStride": 8,
+ "name": "bufferViewFloatVec2"
+ }],
+ "buffers": [{
+ "uri": "ToyCar.bin",
+ "byteLength": 3664368
+ }],
+ "materials": [
+ {
+ "name": "ToyCar",
+ "doubleSided": true,
+ "pbrMetallicRoughness": {
+ "baseColorTexture": {
+ "index": 2
+ },
Good catch.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#278 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJSQ3DF57AILG3P4LLC3DOLSSQLKRANCNFSM4UD5XEIA>
.
|
Alex fixed the indentation using a JSON pretty-formatter for VSCode. This is merged now, thanks!
If you're asking me, the answer is so deep into "Yes" territory that I think it should probably be illegal to use other editing tools on raw glTF text. |
|
Thanks @cx20! I've forwarded your message to the team who hopefully can help. It might be a while due to the holiday season. |
This is the v4 sample model, with materials authored by @echadwick-wayfair. This model is featured in the PBR Next Phase 1 Press Release, showcasing KHR_materials_clearcoat, KHR_materials_transmission, and KHR_materials_sheen.