Fixed shared SkinnedMesh on export #729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 5, 2024 15:39
…t has differences in weight values)
…tHashCode to avoid multiple exports of the same mesh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a SkinnedMesh was used by multiple Nodes, the SkinnedMesh was exported for each Node. Only some attribute accessors was shared between them. Which brokes the instancing capaility.
Now, it will only export the SkinnedMesh once. To keep the support for different blendshape weights settings per node, the weigths gets also written into the node weights property (only when they differs from the first/default weights).
The sample file contains two versions:
Sample Files:
AnimatedMorphCubes.zip