Added support for multiple entrypoints for CLI yaml print #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencer-lunarg
requested changes
Jul 3, 2025
There was a problem hiding this comment.
This looks good, but it will blow up CI as the YAML will all be different
- Rebase this on
main - Build the binary (
mkdir build && cd build && cmake .. && cmake --build .) - run
python tests/build_golden_yaml.pyand it will update all the YAML files, commit this as well, I will use those to review that all the changes makes sense - We merge this in!
Luna5ama
force-pushed
the
cli-yaml-multi-entrypoint
branch
from
fe31181 to
5c91c09
Compare
Luna5ama
commented
Jul 4, 2025
| uav_counter_id: 4294967295 | ||
| uav_counter_binding: | ||
| ByteAddressBuffer offsets: [13, 5, 11, 4] | ||
| ByteAddressBuffer offsets: [4, 5, 11, 13] |
There was a problem hiding this comment.
For whatever reason, the ordering is messed up on Windows with MSVC. It was supposed to be sorted. But that would be another issue and PR. There is already #307 for this.
https://github.com/KhronosGroup/SPIRV-Reflect/blob/main/spirv_reflect.c#L3669-L3674
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #313