Fix OpFPGARegINTEL grammar #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

bashbaug merged 1 commit into KhronosGroup:main from Naghasan:vlom-497

Mar 27, 2025

Member

Naghasan commented Mar 20, 2025

Fix #497


          Fix OpFPGARegINTEL grammar

dc5e615

Naghasan requested a review from bashbaug

March 20, 2025 15:49

Member Author

Naghasan commented Mar 20, 2025

Tested locally: without this change, spirv-dis cannot process the module created by this test https://github.com/intel/llvm/blob/sycl/llvm-spirv/test/extensions/INTEL/SPV_INTEL_fpga_reg/IntelFPGAReg.ll

bashbaug approved these changes

View reviewed changes

Contributor

bashbaug left a comment

LGTM, changes match the spec.

Contributor

bashbaug commented Mar 27, 2025

Merging as discussed in the March 26th teleconference.

bashbaug merged commit 7266457 into KhronosGroup:main

10 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet