XML: Add a few missing requires #1444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Selection of non contentious changes from KhronosGroup#960. Also see KhronosGroup#1426
bashbaug
approved these changes
Aug 18, 2025
| @@ -5711,6 +5749,7 @@ server's OpenCL/api-docs repository. | |||
| <type name="CL/cl_icd.h"/> | |||
| </require> | |||
| <require> | |||
| <type name="cl_icd_dispatch"/> | |||
There was a problem hiding this comment.
I was initially surprised to see this, but since cl_icd_dispatch is used by the clInitLayer function I think it makes sense to add it.
FWIW, the cl_layer.h includes cl_icd.h, which contains the definition of the cl_icd_dispatch structure, but listing cl_icd_dispatch here won't hurt anything. The header generation scripts will generate a forward declaration of the structure, but this is still valid after the structure definition.
CC @Kerilk for awareness.
kpet
approved these changes
Aug 19, 2025
|
Merging as discussed in the August 19th teleconference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selection of non contentious changes from #960. Also see #1426
cl_char,cl_int, ... data typesCL_M_*constantscl_icd_dispatchUnlike #960, it doesn't include
cl_halftype andCL_HALF_*constants. I also movedcl_icd_dispatchinto the group with other types.