error code consistency for platforms and devices #1439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwanC
approved these changes
Aug 22, 2025
api/opencl_platform_layer.asciidoc
Outdated
| ** if _platform_ is not a valid platform | ||
| * {CL_INVALID_VALUE} | ||
| ** if _d3d_device_source_ is not a valid value | ||
| ** if _d3d_object_ is not valid |
There was a problem hiding this comment.
is this error code new? Can't see anything about _d3d_object_ in the previous CL_INVALID_VALUE wording
same question for the clGetDeviceIDsFromD3D11KHR changes
There was a problem hiding this comment.
I think I added this for parity with clGetDeviceIDsFromDX9MediaAdapterKHR, specifically:
CL_INVALID_VALUE if any of the entries in media_adapters_type or media_adapters is not a valid value.
But, you're right, strictly speaking this wasn't an error condition previously. I've commented it out for now, and we can have the discussion later.
Co-authored-by: Ewan Crawford <[email protected]>
|
Merging as discussed in the August 26th teleconference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to partially address the way we document error conditions, see #1320 and in particular #1320 (comment).
It contains a subset of the changes from #1399, specifically for platforms and devices.