clean up inconsistencies for clSetKernelExecInfo error conditions #1419
+8
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is only a CL_INVALID_VALUE error when param_value is NULL if param_value_size is greater than zero. Also tidies up a few of the CL_INVALID_OPERATION error conditions.
|
Do we want this change to apply only when ext_buffer_device_address is supported by the implementation? |
|
No, please have a look at the linked issue. The worst inconsistency is unrelated to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1413
It is only a
CL_INVALID_VALUEerror when param_value isNULLif param_value_size is greater than zero.Also tidies up a few of the
CL_INVALID_OPERATIONerror conditions.