Added test to verify negative result of clSetKernelArg with CL_INVALID_ARG_INDEX #2458
Conversation
| sampler_arg_kernel = clCreateKernel(program, "sample_test", &error); | ||
| test_error(error, "Unable to get sample_test kernel for built program"); | ||
|
|
||
| // Run the test - CL_INVALID_ARG_INDEX |
There was a problem hiding this comment.
This comment doesn't give the reader much extra info as-is, it would add value if instead the comment said that the "sample_test" test kernel has 2 arguments, so 2 is out of range as arguments are indexed from zero.
| test_error(error, "Unable to get sample_test kernel for built program"); | ||
|
|
||
| // Run the test - CL_INVALID_ARG_INDEX | ||
| error = clSetKernelArg(sampler_arg_kernel, 2, sizeof(cl_sampler), nullptr); |
There was a problem hiding this comment.
cl_sampler types aren't used anywhere else in this file, can we use sizeof(cl_mem) to avoid a reader having to work if there's a reason we've started using cl_sampler for this particular test.
| { | ||
| cl_int error = CL_SUCCESS; | ||
| clProgramWrapper program; | ||
| clKernelWrapper sampler_arg_kernel; |
There was a problem hiding this comment.
The kernel names at the top of the file are "sample" rather than "sampler", a "sampler" is a separate concept to what we're trying to test here, so would prefer we didn't complicate the test by using that terminology. Would just call this variable kernel.
Related to #2282, according to work plan from here