Remove semaphores_simple_2 and external_semaphores_simple_2 tests #2447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the cl_khr_semaphore extension spec does state that are no implicit dependencies between already enqueued commands and the clEnqueueSignalSemaphoresKHR, it's nothing special as this is already true for any other event that's not a barrier or marker. Also, the CTS can't reliably assume implementations to reorder events even in an out of order queue as this is highly implementation defined behavior and implementations may or may not choose to reorder events in a specific order. I don't see a reason why this should be tested for semaphores, but not for any other commands, especially as it imposes a restriction on how to implement out of order queues that wasn't enforced before. Closes: KhronosGroup#2439
kpet
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the cl_khr_semaphore extension spec does state that are no implicit dependencies between already enqueued commands and the clEnqueueSignalSemaphoresKHR, it's nothing special as this is already true for any other event that's not a barrier or marker.
Also, the CTS can't reliably assume implementations to reorder events even in an out of order queue as this is highly implementation defined behavior and implementations may or may not choose to reorder events in a specific order.
I don't see a reason why this should be tested for semaphores, but not for any other commands, especially as it imposes a restriction on how to implement out of order queues that wasn't enforced before.
Closes: #2439