-
Notifications
You must be signed in to change notification settings - Fork 261
Fix man page issues introduced by PR #817 #903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to separate listing in command_create.cpp.
Reorganized and with improved explanations.
@wasimabbas-arm are you okay with this? I want to merge it. |
Once my comments are resolved it LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix various @snippet references that were not updated to reflect file and option name changes in PR #817. Add new encode_utils files to ktxtool sources.
Reorganize encoding options and improve explanations in
ktx create
andktx encode
man pages.Changes in
ktx encode
documentation are a pre-cursor to adding ASTC support. Full proposed documentation is there but ASTC portions are commented out. This was proposed in a previously distributed e-mail.@wasimabbas-arm please review. When you add ASTC support to
ktx encode
please ensure the documentation is correct. I don't want to have to spend time fixing it.