Skip to content

Conversation

bkapustik
Copy link
Collaborator

Motivation

Which issue does this fix? Fixes #issue number

If no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious?

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

If manual testing is required, what are the steps?

@bkapustik bkapustik requested a review from a team as a code owner August 13, 2025 14:16
@seangwright
Copy link
Member

seangwright commented Aug 13, 2025

What's the goal of deleting the CI Repository?

It's how we enable the example project set up with pre-defined indexes to make it simple for someone to quickly test the integration.

Maybe you could put some of this information in the PR description.

@hesspavel
Copy link
Collaborator

Hey @seangwright,

Although the PR description lacks a detailed intent, I would like to offer my own explanation.

Even with other integrations where Dancing Goat is used as a test project, hundreds of files from the CI directory are not added to github. Instead, there is a single Template.zip file in the Data folder.

This is updated with each new product release including the Kentico template and DG example.

To update the local database, you then need to extract the contents of the file to the CI directory and run the ci restore command.

Does this make sense?

@seangwright
Copy link
Member

The Template.zip doesn't get updated when we run an update on the Dancing Goat project using Xperience's built-in CLI tools.

It would only be updated if we used dotnet new and created a new project each time we need to update Dancing Goat - is that the plan?

On the other hand, the CI files do get updated when Xperience updates using the CLI tools.

If I'm a developer that's new to this repo and I want to test the Lucene integration, do we expect that developer to initialize the fresh Dancing Goat database and then create all the indexes correctly to work with the example code in the Dancing Goat application? Do we have instructions in the docs on how to correctly set up the indexes?

The CI files include that correct configuration. A developer can restore them and be up and running with the example project without knowing the details of how the integration works.

@seangwright
Copy link
Member

Chatted offline - we're going to remove the CI Repository and rely on the Xperience data in Template.zip to set up a new db. This is a more maintainable long term solution for this repo as we will likely replace the Dancing Goat project code with the latest on a semi-regular basis.

Instructions in the repo will be updated to explain how to create search indexes that work correctly with the Dancing Goat sample integration code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants