Remove snapshot and test specific code #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes snapshot-related functionality from the ChatRPG codebase to simplify the project by eliminating features, methods, and dependencies that are no longer needed.
- Removed DeepCopy methods from several model classes (Campaign, NarrativeGraph, Message, Character).
- Eliminated snapshot saving functionality from persistence services and the related UI components.
- Cleaned up and removed unused dependencies and configuration settings associated with snapshot functionality.
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ChatRPG/Services/ScenarioDocumentService.cs | Removed logger dependency and the snapshot copy method. |
| ChatRPG/Services/IPersistenceService.cs | Removed the SaveSnapshotAsync method signature. |
| ChatRPG/Services/EfPersistenceService.cs | Removed snapshot saving logic and dependency on ScenarioDocumentService. |
| ChatRPG/Pages/CampaignPage.razor.cs | Removed snapshot save method and unused injections (UserManager, Configuration). |
| ChatRPG/Pages/CampaignPage.razor | Removed the 'Save Campaign Snapshot' button from the UI. |
| ChatRPG/Data/Models/NarrativeGraph.cs | Removed the DeepCopy method associated with snapshot creation. |
| ChatRPG/Data/Models/Message.cs | Removed the DeepCopy method used for snapshotting messages. |
| ChatRPG/Data/Models/Character.cs | Removed the DeepCopy method used for snapshotting characters. |
| ChatRPG/Data/Models/Campaign.cs | Removed the DeepCopy method used for snapshotting campaigns. |
Files not reviewed (1)
- ChatRPG/appsettings.json: Language not supported
Sarmisuper
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the campaign snapshot feature from the
ChatRPGproject, including its associated functionality, UI elements, and dependencies. It simplifies the codebase by eliminating methods, services, and configuration settings related to snapshots.Removal of snapshot functionality:
ChatRPG/Data/Models/Campaign.cs: Removed theDeepCopymethod, which created deep copies of campaigns, as it was primarily used for snapshots.ChatRPG/Pages/CampaignPage.razor: Deleted the "Save Campaign Snapshot" button from the UI.ChatRPG/Pages/CampaignPage.razor.cs: Removed theSaveSnapshotAsyncmethod and its dependencies, such asUserManagerandIConfiguration. [1] [2]ChatRPG/Services/EfPersistenceService.cs: Deleted theSaveSnapshotAsyncmethod and removed the dependency onScenarioDocumentService. [1] [2]ChatRPG/Services/IPersistenceService.cs: Removed theSaveSnapshotAsyncmethod from theIPersistenceServiceinterface.Code cleanup and dependency removal:
ChatRPG/Services/ScenarioDocumentService.cs: Eliminated theCopyScenarioEmbeddingForSnapshotmethod and the unusedILoggerdependency. [1] [2]ChatRPG/appsettings.json: Removed theEnableSnapshotsconfiguration setting.Additional cleanup:
ChatRPG/Data/Models/Character.cs: Removed theDeepCopymethod for characters, as it was no longer needed.ChatRPG/Data/Models/Message.cs: Removed theDeepCopymethod for messages.ChatRPG/Data/Models/NarrativeGraph.cs: Removed theDeepCopymethod for narrative graphs.