Additional JDK25 and Quarkus 3.28.1 whitelists

[Karm]

No description provided.

[Karm]

@jerboaa Some more whitelists; GHA does not show it because GHA does not run the full suite.

[jerboaa]

Where do we see those? A better fix would be to run native-image with -J--add-opens=java.base/java.lang=ALL-UNNAMED since we know it's needed for a newly generated quarkus app. This avoids not seeing them when we actually don't expect it.

[Karm]

@jerboaa Quarkus app: https://github.com/Karm/mandrel-integration-tests/tree/master/apps/quarkus-mp-orm-dbs-awt

So while possible with -Dquarkus.native.additional-build-args= not sure if it's the place fir the TS to add it. I assumed it's gonna be fixed with your Q update in the comment.

[jerboaa]

So while possible with -Dquarkus.native.additional-build-args= not sure if it's the place for the TS to add it

I think we should fix it that way. This ensures we don't get the thread-local-reset warning even when running on Mandrel 24+ for quarkus-pm-orm-dbs-awt, but for no other app. The current approach in this patch disables the warning for all apps in the TS when run on Mandrel 25+.

I assumed it's gonna be fixed with your Q update in the comment.

quarkusio/quarkus#47637 fixed it for quarkus-core. Since this is an app generated separately, it'll need the add-opens on launch separately I think. Unless my understanding isn't correct and I miss something.

[Karm]

The current approach in this patch disables the warning for all apps in the TS when run on Mandrel 25+.

Not true, it affects only this app: QUARKUS_MP_ORM_DBS_AWT

So it's really a matter of either adding the -J--add-opens to the command line or whitelisting it here.

I am O.K. with adding it to the app's command line though, so I'll refactor it...

[jerboaa]

The current approach in this patch disables the warning for all apps in the TS when run on Mandrel 25+.

Not true, it affects only this app: QUARKUS_MP_ORM_DBS_AWT

Ah, right. My bad.

[Karm]

@jerboaa So I have this major refactor coming that deals with --add-opens=java.base/java.lang=ALL-UNNAMED and --enable-native-access=ALL-UNNAMED everywhere and as usual it's a kind of a mess, e.g. the way we do things , adding -Dquarkus.native.additional-build-args= doesn't help HotSpot run, that needs to be adjusted in pom.xml/JAVA_OPTS and also appending -Dquarkus.native.additional-build-args= overrides the same property in application.properties files.
Gonna sort it and re-test it.

WhiteList all such things as originally done in this PR "just works" but I agree it's a somewhat lazy approach.

[jerboaa]

Fair enough.

[Karm]

Oh, 🤦 my local terminal had in it's env

export JAVA_OPTS="--enable-native-access=ALL-UNNAMED --add-opens=java.base/java.lang=ALL-UNNAMED";
export MAVEN_OPTS="--enable-native-access=ALL-UNNAMED --add-opens=java.base/java.lang=ALL-UNNAMED";

so that's why these didn't fail for me locally.

Fixing...

[Karm]

Latest Quarkus needs porting for the container run:

Build step io.quarkus.datasource.deployment.devservices.DevServicesDatasourceProcessor#launchDatabases
threw an exception: io.quarkus.runtime.configuration.ConfigurationException: Cannot set a port for the Dev Service
of datasource 'quarkus.datasource."db1".devservices.port' using 'datasource db1',
because it is using a shared network, which disables port mapping 

Also a continuation of SmallRye Command "we treat anything in stderr as a warning" :-(

Warning:  [io.smallrye.common.process] SRCOM05000: Command docker (pid 24262) completed but logged errors:

Fixing...

[Karm]

Latest Quarkus needs porting for the container run:

Build step io.quarkus.datasource.deployment.devservices.DevServicesDatasourceProcessor#launchDatabases
threw an exception: io.quarkus.runtime.configuration.ConfigurationException: Cannot set a port for the Dev Service
of datasource 'quarkus.datasource."db1".devservices.port' using 'datasource db1',
because it is using a shared network, which disables port mapping 

Also a continuation of SmallRye Command "we treat anything in stderr as a warning" :-(

Warning:  [io.smallrye.common.process] SRCOM05000: Command docker (pid 24262) completed but logged errors:

Fixing...

It's quarkusio/quarkus#50015

Contemporary Quarkus doesn't need that so I switched ports to dev profile only.

[Karm]

@jerboaa So the topic of opening java.base to ALL-UNNAMED and allowing native access to ALL-UNNAMED is resolved with this PR in both pertinent areas:

• Maven itself via .mvn properties
• native-image via -J flag, sometimes as a command line arg, sometimes in application.properties

[jerboaa]

Thanks!