Skip to content
This repository was archived by the owner on Jun 22, 2024. It is now read-only.

Conversation

SMEISEN
Copy link
Collaborator

@SMEISEN SMEISEN commented Dec 16, 2021

Description

implements the condition module

Related Issues

closes #169

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos)
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Did you update the CHANGELOG

PR review

Anyone in the community is free to review the PR once the tests have passed.

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones to the PR so it can be classified

@SMEISEN SMEISEN requested a review from benHeid November 17, 2022 11:29
@benHeid benHeid force-pushed the feature/169_condition_module branch from eca62b9 to c6db5fc Compare November 23, 2022 09:33
Copy link
Collaborator

@benHeid benHeid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR. Please add an entry in the Changelog and create a documentation for this module via sphinx-autodoc.

@@ -0,0 +1,9 @@
class InvalidInputException(Exception):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class is no part of pywatts-pipeline. Thus, please remove it from the PR.

@SMEISEN SMEISEN requested a review from benHeid February 24, 2023 11:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Condition module

2 participants