-
Notifications
You must be signed in to change notification settings - Fork 3
Development #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Development #3
Changes from 54 commits
35d727c
538fec7
848cc66
bd0f2cb
02b250c
cedd76b
57259b5
793174a
2fa163f
b54b126
20ff4b7
54c96b2
55b52db
b583179
9cd5431
25e42b3
e4e6351
a9c5b0f
7a4383a
3dfb191
61a0359
9f7bf0c
edcdf41
02a4d1d
e665841
b01d48b
671ebb2
790c28f
e608d71
ea879e1
d2e9847
f742cd9
b87e90e
569687c
c89a520
cd9a9f0
ff974a2
52a52b8
e638d0f
4846c89
ab92acb
6f65658
0f80be7
22ecf3a
a1b00ad
deb3ec8
63cfd5f
082a48e
2660983
0e71ca9
49c95c5
751b47b
a6c03ad
385af39
d274f18
8552395
df2f5ce
ce5ef74
1ad28a4
8bcd162
3a8b87a
f7bcf73
f2d5ce9
381046a
fdd8d46
76f18bb
9258017
65984ce
1242ef1
0b2e6f7
31295ee
1700019
1632d47
abad481
f3bb537
b98945e
02394c6
a1e4ad9
45cbae5
50c6de9
0b8746c
8a7c14b
d648ea2
bbd2dec
24ba01b
72351b3
500bf6d
b56c11f
ae1e899
99344c5
0f00f77
71b4892
c444e86
a813c21
2d07b0d
1f9ad12
75fa1d2
b252a8e
b0b3d92
a2a133b
ae36ac5
013372b
0d071d9
8f94c2d
c2b74a5
bdddeec
a5f1884
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,6 @@ | ||
CLIENT_ID= | ||
CLIENT_SECRET= | ||
CLIENT_SECRET= | ||
TENANT= | ||
FINDING_SEVERITY= | ||
FINDING_LIMIT= | ||
BASE_URL_API= | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,3 +5,4 @@ dist/ | |
.env | ||
.eslintcache | ||
tsconfig.tsbuildinfo | ||
coverage/ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thank you for adding this to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @aiwilliams I have removed all the files related to the code coverage |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -96,21 +96,33 @@ https://github.com/JupiterOne/sdk/blob/main/docs/integrations/development.md | |
|
||
The following entities are created: | ||
|
||
| Resources | Entity `_type` | Entity `_class` | | ||
| --------- | -------------- | --------------- | | ||
| Account | `acme_account` | `Account` | | ||
| User | `acme_user` | `User` | | ||
| UserGroup | `acme_group` | `UserGroup` | | ||
| Resources | Entity `_type` | Entity `_class` | | ||
| ------------- | ---------------------------------- | ---------------- | | ||
| Account | `microsoft_defender_account` | `Account` | | ||
| CVE | `cve` | `Vulnerability` | | ||
| Device | `user_endPoint` | `Device`, `Host` | | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As mentioned elsewhere, this should be |
||
| Machine | `microsoft_defender_machine` | `HostAgent` | | ||
| User | `microsoft_defender_logon_user` | `User` | | ||
| Vulnerability | `microsoft_defender_vulnerability` | `Finding` | | ||
|
||
### Relationships | ||
|
||
The following relationships are created: | ||
|
||
| Source Entity `_type` | Relationship `_class` | Target Entity `_type` | | ||
| --------------------- | --------------------- | --------------------- | | ||
| `acme_account` | **HAS** | `acme_group` | | ||
| `acme_account` | **HAS** | `acme_user` | | ||
| `acme_group` | **HAS** | `acme_user` | | ||
| Source Entity `_type` | Relationship `_class` | Target Entity `_type` | | ||
| ---------------------------- | --------------------- | ---------------------------------- | | ||
| `microsoft_defender_account` | **HAS** | `microsoft_defender_machine` | | ||
| `microsoft_defender_machine` | **HAS** | `microsoft_defender_logon_user` | | ||
| `microsoft_defender_machine` | **IDENTIFIED** | `microsoft_defender_vulnerability` | | ||
|
||
### Mapped Relationships | ||
|
||
The following mapped relationships are created: | ||
|
||
| Source Entity `_type` | Relationship `_class` | Target Entity `_type` | Direction | | ||
| ---------------------------------- | --------------------- | --------------------- | --------- | | ||
| `microsoft_defender_machine` | **MANAGES** | `*user_endPoint*` | FORWARD | | ||
| `microsoft_defender_vulnerability` | **IS** | `*cve*` | FORWARD | | ||
|
||
<!-- | ||
******************************************************************************** | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,4 @@ | ||
module.exports = require('@jupiterone/integration-sdk-dev-tools/config/jest'); | ||
module.exports = { | ||
...require('@jupiterone/integration-sdk-dev-tools/config/jest'), | ||
setupFiles: ['dotenv/config'], | ||
}; | ||
Comment on lines
+1
to
+4
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These lines should be deleted. Line 1 already exports the content of line 3 here, and the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @aiwilliams , repeated line is removed . There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This file should be exactly:
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't appear to be defined anywhere in the PR. What is the value supposed to be and how would a user know? Is this not a static value for all users?