junos-eznc 2.7.3: SW install function raised bug error when upgrading device with virtual-chassis

[sjtiantang]

Hi Team,
I'm upgrading a ex4300mp from 20.2R3.9 to 21.4R3-S10.9, while running the install function, it raised error:

    ok, msg = sw_instance.install(
              ^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/jnpr/junos/utils/sw.py", line 1042, in install
    vc_members.remove(self.dev.facts["vc_master"])
ValueError: list.remove(x): x not in list

This is the output of my show virtual-chassis command:

show virtual-chassis

Preprovisioned Virtual Chassis
Virtual Chassis ID: <id>
Virtual Chassis Mode: Enabled
                                                Mstr           Mixed Route Neighbor List
Member ID  Status   Serial No    Model          prio  Role      Mode  Mode ID  Interface
0 (FPC 0)  Prsnt    <serial-number> ex4300-48mp    129   Master*      N  VC   1  vcp-255/1/2
                                                                           2  vcp-255/1/3
1 (FPC 1)  Prsnt    <serial-number> ex4300-48mp      0   Linecard     N  VC   2  vcp-255/1/2
                                                                           0  vcp-255/1/3
2 (FPC 2)  Prsnt    <serial-number> ex4300-48mp      0   Linecard     N  VC   0  vcp-255/1/2
                                                                           1  vcp-255/1/3

I have junos-eznc version 2.7.3

Thanks a lot in advance for your time and help!

[sjtiantang]

I checked the dev.facts of my device, this is what I have for "junos_info":

'junos_info': {'fpc1': {'object': junos.version_info(major=(20, 2), type=R, minor=3, build=9),
                         'text': '20.2R3.9'},
                'fpc2': {'object': junos.version_info(major=(20, 2), type=R, minor=3, build=9),
                         'text': '20.2R3.9'},
                'localre': {'object': junos.version_info(major=(20, 2), type=R, minor=3, build=9),
                            'text': '20.2R3.9'}},

Based on the logic in here: https://github.com/Juniper/py-junos-eznc/blob/master/lib/jnpr/junos/utils/sw.py#L1037C21-L1041, the rendered vc_members should be vc_members = ['1', '2']

And: 'vc_master': '0',

Seems like junos_info has already excluded the vc_master, therefore causing error when removing a non-existing item from list.

[sjtiantang]

From the logic, looks like it's upgrading all the vc members first, then finally upgrade the master. Then may I suggest this simple change? #1369

[sjtiantang]

@chidanandpujar @dineshbaburam91 , could you please help to review this simple fix, thanks

[chidanandpujar]

Hi @sjtiantang ,
Thanks for the fix #1369,
I will review it and update.

Thanks
Chidanand

[sjtiantang]

@chidanandpujar thanks for assigning this. Do you have any update on this?

[chidanandpujar]

@chidanandpujar thanks for assigning this. Do you have any update on this?

Hi @sjtiantang,
I am trying to borrow the VC setup from internal test team to validate your fix.
After validation of the fix, we will proceed with fix merge.

Thanks
Chidanand

[chidanandpujar]

Hi @sjtiantang,
Fix looks to be working fine.

root@masterhost:~# cat sw_install.py 
from jnpr.junos import Device
from xml.etree import ElementTree as etree
from pprint import pprint
from jnpr.junos.utils.sw import SW
#import logging
#logging.basicConfig( level=logging.DEBUG)
 
dev = Device(host='xyz', user='xyz', password='xyz', gather_facts=False, port=22, huge_tree=True)
dev.open()
 
def myprogress(dev, report):
        print("host: {}, report: {}".format( dev.hostname, report))
pkg = "xyz.tgz"
sw = SW(dev)
ok, msg = sw.install(package=pkg,
                     validate=False,
                     remote_path='/var/tmp',
                     progress=myprogress,
                     no_copy=True,
                     force_host=False,
                     reboot=False,
                     issu=False,
                     nssu = False,
                     cleanfs=False,
                     vmhost=False,
                     force_copy=False,
                     timeout=8000)
if ok:
   #sw.reboot()
   print("Pass")

<partial logs attached for referrence>

root@masterhost:~# vi sw_install.py 
root@masterhost:~# python3 sw_install.py 
host: systest-ex43mp-p1c-02, report: request-package-checks-pending-install rpc is not supported on given device
host: systest-ex43mp-p1c-02, report: validating software against current config, please be patient ...
host: systest-ex43mp-p1c-02, report: installing software on VC member: 1 ... please be patient ...
host: systest-ex43mp-p1c-02, report: software pkgadd package-result: 0
Output: 

[Mar 28 02:51:10]: Checking pending install on fpc1

Host OS upgrade staged. Reboot the system to complete installation!

Install completed
host: systest-ex43mp-p1c-02, report: installing software on VC member: 2 ... please be patient ...
host: systest-ex43mp-p1c-02, report: software pkgadd package-result: 0
Output: 

[Mar 28 03:00:49]: Checking pending install on fpc2


Host OS upgrade staged. Reboot the system to complete installation!

Install completed
host: systest-ex43mp-p1c-02, report: installing software on VC member: 0 ... please be patient ...
host: systest-ex43mp-p1c-02, report: software pkgadd package-result: 0

Host OS upgrade staged. Reboot the system to complete installation!

Install completed

Pass

[sjtiantang]

Thank you @chidanandpujar !

[sjtiantang]

@chidanandpujar , btw sir is this code change going to be reflected in eznc 2.7.4?