Fixing exists by adding keywords #167
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevengj
reviewed
Feb 8, 2020
| @@ -192,7 +192,11 @@ end | |||
| const PkgOrPkgs = Union{AbstractString, AbstractVector{<: AbstractString}} | |||
|
|
|||
| "Install a new package or packages." | |||
| function add(pkg::PkgOrPkgs, env::Environment=ROOTENV; channel::AbstractString="") | |||
| function add(pkg::PkgOrPkgs; env::Environment=ROOTENV, channel::AbstractString="") | |||
There was a problem hiding this comment.
This is a breaking change. You should add:
@deprecate add(pkg::PkgOrPkgs, env::Environment; channel::AbstractString="") add(pkg, env=env, channel=channel)and similar so that callers using the old API still function, albeit with a warning message.
stevengj
reviewed
Feb 8, 2020
src/Conda.jl
Outdated
| add(pkg,env,channel) | ||
| end | ||
|
|
||
| function add(pkg::PkgOrPkgs, env::Environment, channel::AbstractString="") |
There was a problem hiding this comment.
Why is this 3-argument version here?
There was a problem hiding this comment.
We should just have the keyword version, plus a deprecated 2-arg version, if we want to do this.
|
Hi. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exists doesn't work when you have an environment that's a string, such as if you have a different root environment. The first commit just addresses exists, while the second one adds keyword values inspired by #118.