Skip to content

Conversation

Ickaser
Copy link
Contributor

@Ickaser Ickaser commented Jul 4, 2025

Description

Attribution

Things to consider

  • Does it work on log scales?
  • Does it work in layouts?
  • Does it work in recipes?
  • Does it work with multiple series in one call?
  • PR includes or updates tests?
  • PR includes or updates documentation?

@Ickaser
Copy link
Contributor Author

Ickaser commented Jul 4, 2025

As is, this should address only things that were covered in #5098 and #5127.

To fully resolve #5093, JuliaPhysics/Unitful.jl#795 and jw3126/UnitfulRecipes.jl#81 will need to merge so that the Unitful extension can drop its UnitfulLatexify dependency and someone who loads Plots and Unitful (but doesn't need Latexify) will still have the extension load. I think that is perhaps best handled as another PR since it will involve touching a bunch of Project.toml files.

@t-bltg
Copy link
Member

t-bltg commented Jul 4, 2025

FYI, I've changed the default formatter for the Plots repo, so now you have to use:

$ julia -e 'using Runic; exit(Runic.main(ARGS))' -- --inplace .

@Ickaser
Copy link
Contributor Author

Ickaser commented Jul 4, 2025

The test failure here is because I didn't keep good track of what was new in JuliaPhysics/Unitful.jl#795. When I get a chance I will change the test to reflect UnitfulLatexify's old behavior, unless that other one gets merged and released really fast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants