WIP 1.6 Artifacts JLL generation #880
Conversation
staticfloat
force-pushed
the
sf/artifacts_stdlib
branch
from
bb517f8 to
0fd7e19
Compare
src/AutoBuild.jl
Outdated
| copying the artifact over to a local `override` directory, allowing package | ||
| developers to experiment with a locally-built binary. | ||
| \"\"\" | ||
| function dev_jll() |
There was a problem hiding this comment.
Can't we add something to Pkg or BinaryBuilder to not have to put this into every jll? Like BinaryBuilder.dev("...")?
There was a problem hiding this comment.
There was a problem hiding this comment.
That's loaded by every jll files as well though? It just feels like the wrong place to put it, tools for developing the package shouldn't have to be compiled into the package itself imo. It should be handled by some external thing like JLLDeveloperTools.jl or just BinaryBuilder.
There was a problem hiding this comment.
That's an interesting point of view.
There was a problem hiding this comment.
I mean, packages don't need an update_me() function bundled with them and compiled into their .ji file nor do they need to depend on Pkg to be updatable. Because the process of updating a package is handled externally (and is independent) to the functionality of the package itself. This feels like kinda the same thing. If we want to make the jlls (and the common package they depend on) small, then moving everything dev-like that the package won't run itself during normal execution out to a developer package seems reasonable.
There was a problem hiding this comment.
To be clear, I think you're probably right that the function doesn't need to be here at all 😅
staticfloat
force-pushed
the
sf/artifacts_stdlib
branch
from
0fd7e19 to
d94f77f
Compare
Co-authored-by: Mosè Giordano <[email protected]>
Changing JLL generation to use the new 1.6
Artifactsstdlib, instead of Pkg, and optimizing things to do more work at compile time.