Skip to content

Conversation

pkofod
Copy link
Member

@pkofod pkofod commented Mar 31, 2025

No description provided.

Copy link
Contributor

Benchmark Results

master 90db36f... master / 90db36f...
multivariate/solvers/first_order/AdaMax 0.65 ± 0.0078 ms 0.653 ± 0.0075 ms 0.995
multivariate/solvers/first_order/Adam 0.649 ± 0.0076 ms 0.652 ± 0.0076 ms 0.995
multivariate/solvers/first_order/BFGS 0.225 ± 0.005 ms 0.225 ± 0.0047 ms 1
multivariate/solvers/first_order/ConjugateGradient 0.0481 ± 0.00059 ms 0.0481 ± 0.00074 ms 1
multivariate/solvers/first_order/GradientDescent 1.71 ± 0.016 ms 1.71 ± 0.015 ms 1
multivariate/solvers/first_order/LBFGS 0.22 ± 0.0042 ms 0.221 ± 0.0042 ms 0.998
multivariate/solvers/first_order/MomentumGradientDescent 2.52 ± 0.02 ms 2.51 ± 0.019 ms 1
multivariate/solvers/first_order/NGMRES 0.556 ± 0.011 ms 0.557 ± 0.01 ms 0.999
time_to_load 0.529 ± 0.012 s 0.528 ± 0.0039 s 1

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

Copy link

codecov bot commented Mar 31, 2025

Codecov Report

Attention: Patch coverage is 16.66667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 85.91%. Comparing base (a4fc81d) to head (90db36f).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/types.jl 25.00% 6 Missing ⚠️
src/maximize.jl 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1157      +/-   ##
==========================================
- Coverage   85.96%   85.91%   -0.05%     
==========================================
  Files          46       46              
  Lines        3584     3622      +38     
==========================================
+ Hits         3081     3112      +31     
- Misses        503      510       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pkofod pkofod merged commit 6bcbc53 into master Mar 31, 2025
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant