Skip to content

Format repository #1150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 28, 2025
Merged

Format repository #1150

merged 2 commits into from
Mar 28, 2025

Conversation

pkofod
Copy link
Member

@pkofod pkofod commented Mar 28, 2025

No description provided.

@pkofod pkofod changed the title Pkm/format2 Format repository Mar 28, 2025
Copy link

codecov bot commented Mar 28, 2025

Codecov Report

Attention: Patch coverage is 85.30997% with 109 lines in your changes missing coverage. Please review.

Project coverage is 85.94%. Comparing base (ae47348) to head (bf99d45).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...tivariate/solvers/constrained/ipnewton/interior.jl 79.82% 23 Missing ⚠️
src/multivariate/solvers/constrained/fminbox.jl 75.00% 15 Missing ⚠️
src/multivariate/solvers/constrained/samin.jl 57.14% 12 Missing ⚠️
src/deprecate.jl 0.00% 10 Missing ⚠️
src/api.jl 76.31% 9 Missing ⚠️
src/multivariate/optimize/interface.jl 73.52% 9 Missing ⚠️
src/maximize.jl 60.00% 8 Missing ⚠️
...riate/solvers/constrained/ipnewton/iplinesearch.jl 54.54% 5 Missing ⚠️
src/Manifolds.jl 88.88% 3 Missing ⚠️
src/multivariate/solvers/first_order/bfgs.jl 82.35% 3 Missing ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1150      +/-   ##
==========================================
+ Coverage   85.88%   85.94%   +0.05%     
==========================================
  Files          46       46              
  Lines        3577     3585       +8     
==========================================
+ Hits         3072     3081       +9     
+ Misses        505      504       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Benchmark Results

master bf99d45... master / bf99d45...
multivariate/solvers/first_order/AdaMax 0.649 ± 0.0077 ms 0.648 ± 0.0078 ms 1
multivariate/solvers/first_order/Adam 0.647 ± 0.0075 ms 0.648 ± 0.0077 ms 0.998
multivariate/solvers/first_order/BFGS 0.224 ± 0.0054 ms 0.225 ± 0.0053 ms 0.998
multivariate/solvers/first_order/ConjugateGradient 0.048 ± 0.00059 ms 0.0479 ± 0.00061 ms 1
multivariate/solvers/first_order/GradientDescent 1.71 ± 0.018 ms 1.72 ± 0.018 ms 0.997
multivariate/solvers/first_order/LBFGS 0.22 ± 0.0045 ms 0.22 ± 0.0058 ms 0.999
multivariate/solvers/first_order/MomentumGradientDescent 2.52 ± 0.018 ms 2.51 ± 0.021 ms 1
multivariate/solvers/first_order/NGMRES 0.554 ± 0.011 ms 0.556 ± 0.011 ms 0.996
time_to_load 0.545 ± 0.0099 s 0.558 ± 0.0054 s 0.977

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@pkofod pkofod merged commit fe4ebf3 into master Mar 28, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant