-
Notifications
You must be signed in to change notification settings - Fork 234
Support autodiff with DifferentiationInterface #1131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The test failures might be fixed by #1073 |
Yeah I don't think they're related to this PR |
I merged 1073 |
or, @blegat looking at
were more tests added that we need to exclude? |
Yes, there might just be new tests that need to be excluded |
one of them is this https://github.com/jump-dev/MathOptInterface.jl/blob/6bfca94b728e48a7800caf26bcc749fae86e0bc7/src/Test/test_nonlinear.jl#L1847-L1870 does that need to be excluded? |
Looking at the NLSolversBase PR again, there is this comment that never got an answer about |
I inserted #1133 into this PR |
Seems like one is saying that a nonlinear objective is not present but I cannot make out if it should be there or not. The other one is an IPNewton that fails and I'm not sure if that could be related to the constraint function you're referring to above. |
Do those checks also fail on main or #1133 without the new NLSolversBase, eg if we upper bound its compat to before the DI integration? |
Ill check later, good question ! |
Having a baseline of failing tests is not great for adding new features 😅 if they have been failing for a while perhaps they can be marked as |
Let's see what we get from #1133 |
Also failed there. Let's try #1134 |
Note that #1133 failed on Julia 1.6 first, where the DI-upgraded NLSolversBase cannot even be installed |
You can try to resolve the conflicts due to the bounds I added on master to see what happens here now |
@pkofod I merged master into this branch, let's see what blows up |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1131 +/- ##
==========================================
- Coverage 86.57% 86.23% -0.34%
==========================================
Files 45 46 +1
Lines 3537 3531 -6
==========================================
- Hits 3062 3045 -17
- Misses 475 486 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Okay, seems to pass. codecov complains about an unhit method, but it seems to have been like that before as well. |
Preliminary PR to run tests with the new version of NLSolversBase (which includes DI)
How should we document and test this more properly?